-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Loading train_dataloader
before estimating max_batches
#20148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading train_dataloader
before estimating max_batches
#20148
Conversation
f138df5
to
af3648f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20148 +/- ##
=========================================
- Coverage 89% 81% -8%
=========================================
Files 267 264 -3
Lines 23071 23019 -52
=========================================
- Hits 20572 18611 -1961
- Misses 2499 4408 +1909 |
af3648f
to
96d25e9
Compare
@shihchengli could you please add a test for this change? 🦩 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions. |
This pull request is going to be closed. Please feel free to reopen it or create a new one based on top of the 'master' branch. |
What does this PR do?
Fixes #16060
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20148.org.readthedocs.build/en/20148/