Skip to content

Conversation

shihchengli
Copy link

@shihchengli shihchengli commented Aug 1, 2024

What does this PR do?

Fixes #16060

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20148.org.readthedocs.build/en/20148/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 1, 2024
@shihchengli shihchengli marked this pull request as ready for review August 1, 2024 03:22
@shihchengli shihchengli force-pushed the fix_num_training_batches branch from f138df5 to af3648f Compare August 5, 2024 15:49
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81%. Comparing base (345450b) to head (af3648f).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (345450b) and HEAD (af3648f). Click for more details.

HEAD has 87 uploads less than BASE
Flag BASE (345450b) HEAD (af3648f)
gpu 4 2
pytest 25 2
lightning_fabric 7 0
lightning 31 16
cpu 41 21
python3.9 12 6
python3.10 12 6
python3.11 12 6
python3.12 5 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20148     +/-   ##
=========================================
- Coverage      89%      81%     -8%     
=========================================
  Files         267      264      -3     
  Lines       23071    23019     -52     
=========================================
- Hits        20572    18611   -1961     
- Misses       2499     4408   +1909     

@shihchengli shihchengli force-pushed the fix_num_training_batches branch from af3648f to 96d25e9 Compare August 9, 2024 05:23
@Borda
Copy link
Collaborator

Borda commented Mar 14, 2025

@shihchengli could you please add a test for this change? 🦩

Copy link

stale bot commented Apr 16, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 16, 2025
Copy link

stale bot commented Apr 27, 2025

This pull request is going to be closed. Please feel free to reopen it or create a new one based on top of the 'master' branch.

@stale stale bot closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package won't fix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

num_training_batches is inf in configure_optimizers

2 participants