Skip to content

Loading train_dataloader before estimating max_batches #20148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Loading train_dataloader before estimating max_batches #20148

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
96d25e9
Loading `train_dataloader` before estimating `max_batches`
shihchengli Aug 1, 2024
f75cf6c
Merge branch 'master' into fix_num_training_batches
shihchengli Aug 12, 2024
f9cce55
Merge branch 'master' into fix_num_training_batches
shihchengli Aug 24, 2024
d80ff17
Merge branch 'master' into fix_num_training_batches
Borda Sep 30, 2024
6a631c5
Merge branch 'master' into fix_num_training_batches
shihchengli Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lightning/pytorch/trainer/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1518,6 +1518,9 @@ def predict_dataloaders(self) -> Optional[EVAL_DATALOADERS]:
@property
def num_training_batches(self) -> Union[int, float]:
"""The number of training batches that will be used during ``trainer.fit()``."""
if self.train_dataloader is None:
rank_zero_info("Loading `train_dataloader` to estimate number of training batches.")
self.fit_loop.setup_data()
return self.fit_loop.max_batches

@property
Expand Down