Skip to content

Conversation

LukasSalchow
Copy link
Contributor

@LukasSalchow LukasSalchow commented Dec 6, 2024

What does this PR do?

Fix 20462

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20471.org.readthedocs.build/en/20471/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83%. Comparing base (de7c28a) to head (3260675).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20471     +/-   ##
=========================================
- Coverage      88%      83%     -5%     
=========================================
  Files         267      267             
  Lines       23284    23287      +3     
=========================================
- Hits        20387    19314   -1073     
- Misses       2897     3973   +1076     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Dec 9, 2024
@lantiga
Copy link
Collaborator

lantiga commented Dec 10, 2024

Merging, this needs further changes but I'll do this in a quick follow-up PR

@lantiga lantiga merged commit 64d0d02 into Lightning-AI:master Dec 10, 2024
75 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type Error in configure_optimizers

2 participants