Skip to content

Fix TypeError in configure_optimizers when running with ReduceLROnPlateau #20471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Fix TypeError in configure_optimizers when running with ReduceLROnPlateau #20471

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c3944f
fix TypeError in configure_optimizers
Dec 6, 2024
7c723b2
Merge branch 'master' into pr_type_error_in_configure_optimizers
lantiga Dec 8, 2024
7789d64
Merge branch 'master' into pr_type_error_in_configure_optimizers
lantiga Dec 9, 2024
3260675
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/lightning/pytorch/utilities/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,18 +104,25 @@ class LRSchedulerConfigType(TypedDict, total=False):
strict: bool


class OptimizerLRSchedulerConfig(TypedDict):
class OptimizerConfigDict(TypedDict):
optimizer: Optimizer
lr_scheduler: NotRequired[Union[LRSchedulerTypeUnion, LRSchedulerConfigType]]


class OptimizerLRSchedulerConfigDict(TypedDict):
optimizer: Optimizer
lr_scheduler: Union[LRSchedulerTypeUnion, LRSchedulerConfigType]
monitor: NotRequired[str]


OptimizerLRScheduler = Optional[
Union[
Optimizer,
Sequence[Optimizer],
tuple[Sequence[Optimizer], Sequence[Union[LRSchedulerTypeUnion, LRSchedulerConfig]]],
OptimizerLRSchedulerConfig,
Sequence[OptimizerLRSchedulerConfig],
OptimizerConfigDict,
OptimizerLRSchedulerConfigDict,
Sequence[OptimizerConfigDict],
Sequence[OptimizerLRSchedulerConfigDict],
]
]

Expand Down
Loading