Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jun 17, 2025

…og parser

What does this PR do?

addresses https://github.com/Lightning-AI/pytorch-lightning/actions/runs/15691157537/job/44206405968

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20912.org.readthedocs.build/en/20912/

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jun 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to .github/workflows/ci-tests-fabric.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48%. Comparing base (c03660a) to head (ffa5aaa).
⚠️ Report is 202 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c03660a) and HEAD (ffa5aaa). Click for more details.

HEAD has 383 uploads less than BASE
Flag BASE (c03660a) HEAD (ffa5aaa)
cpu 107 27
python 12 3
lightning_fabric 26 12
pytest 56 27
python3.10 24 6
python3.12.7 35 9
python3.12 12 3
lightning 60 15
python3.11 24 6
gpu 3 0
pytorch2.1 12 0
pytorch_lightning 24 0
pytest-full 54 0
pytorch2.2.2 6 0
pytorch2.5 6 0
pytorch2.3 6 0
pytorch2.7 6 0
pytorch2.4.1 6 0
pytorch2.5.1 6 0
pytorch2.6 6 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20912     +/-   ##
=========================================
- Coverage      87%      48%    -39%     
=========================================
  Files         268      265      -3     
  Lines       23442    23386     -56     
=========================================
- Hits        20391    11272   -9119     
- Misses       3051    12114   +9063     

@justusschock
Copy link
Member

according to some online posts, this was fixed by setting GLOO_SOCKET_IFNAME. Can we try this instead of marking it as flaky?

@Borda
Copy link
Collaborator Author

Borda commented Jun 17, 2025

according to some online posts, this was fixed by setting GLOO_SOCKET_IFNAME. Can we try this instead of marking it as flaky?

could you pls link the posts? 🙏

@Borda Borda changed the title Mark flaky test_collective_operations for Fabric bc of SIGABRT debugging flaky test_collective_operations with SIGABRT Jun 17, 2025
@github-actions github-actions bot added the ci Continuous Integration label Jun 17, 2025
@Borda Borda merged commit 2358ed3 into master Jun 17, 2025
41 checks passed
@Borda Borda deleted the flaky/test_collective_operations branch June 17, 2025 13:11
Borda added a commit that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration fabric lightning.fabric.Fabric

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants