Skip to content

Conversation

matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Aug 31, 2025

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21132.org.readthedocs.build/en/21132/

@github-actions github-actions bot added the ci Continuous Integration label Aug 31, 2025
@matsumotosan
Copy link
Contributor Author

Still WIP. Trying to figure out how Github workflow matrices work.

@Borda
Copy link
Contributor

Borda commented Aug 31, 2025

Still WIP. Trying to figure out how Github workflow matrices work.

We used to have matrix but with it the additional include and exclude was so complex so this just include was easier to read and maintain

@Borda Borda changed the title Simplify workflow matrix Simplify workflow matrix [wip] Aug 31, 2025
@Borda Borda changed the title Simplify workflow matrix [wip] Simplify workflow matrix Sep 1, 2025
@Borda Borda merged commit db77fa7 into Lightning-AI:master Sep 1, 2025
47 checks passed
@matsumotosan matsumotosan deleted the simplify-workflow-matrix branch September 1, 2025 15:00
Borda pushed a commit that referenced this pull request Sep 3, 2025
* simplify
* add config field

(cherry picked from commit db77fa7)
lantiga pushed a commit that referenced this pull request Sep 5, 2025
* simplify
* add config field

(cherry picked from commit db77fa7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants