Skip to content

Conversation

@bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Nov 25, 2025

What does this PR do?

Fixes docs build in master branch.

image
WARNING: py:data reference target not found: typing.Union
--
build finished with problems, 582 warnings.
make: *** [Makefile:31: html] Error 1

ref: https://github.com/Lightning-AI/torchmetrics/actions/runs/18839686293/job/53748746696

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3306.org.readthedocs.build/en/3306/

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 25, 2025
@bhimrazy bhimrazy changed the title docs: add nitpicky_ignore for typing.Union in Sphinx configuration docs: add nitpicky_ignore for typing.Union in Sphinx configuration to fix build docs Nov 25, 2025
@bhimrazy bhimrazy changed the title docs: add nitpicky_ignore for typing.Union in Sphinx configuration to fix build docs fix: sphinx docs build error due to warnings Nov 27, 2025
@bhimrazy bhimrazy marked this pull request as draft November 28, 2025 07:00
@bhimrazy bhimrazy mentioned this pull request Nov 28, 2025
4 tasks
@bhimrazy bhimrazy marked this pull request as ready for review November 28, 2025 09:24
@mergify mergify bot added the ready label Dec 1, 2025
@Borda
Copy link
Collaborator

Borda commented Dec 1, 2025

@bhimrazy
Copy link
Collaborator Author

bhimrazy commented Dec 1, 2025

build HTML is still failing: https://github.com/Lightning-AI/torchmetrics/actions/runs/19759714343/job/56757882195?pr=3306

yes @Borda , the failure seems related with CI spacing.
image

do we need to clear some cache or try something else to fix this?

@Borda
Copy link
Collaborator

Borda commented Dec 1, 2025

we need to clear some cache or try something else to fix this?

You can nuke the cache and prove that the cache is the problem, you can just disable it in the workflow

@mergify mergify bot added ready and removed ready labels Dec 3, 2025
Copilot AI review requested due to automatic review settings December 3, 2025 16:45
Copilot finished reviewing on behalf of bhimrazy December 3, 2025 16:47
Revert "refactor: remove unused PYPI_CACHE variable and update disk space cleanup step"

This reverts commit 03916b4.
@bhimrazy
Copy link
Collaborator Author

bhimrazy commented Dec 3, 2025

Finally, the failing build issue is resolved. 🚀

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37%. Comparing base (88bca94) to head (2d929a5).

❌ Your project check has failed because the head coverage (37%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #3306    +/-   ##
=======================================
- Coverage      37%     37%    -1%     
=======================================
  Files         364     349    -15     
  Lines       20096   19901   -195     
=======================================
- Hits         7520    7326   -194     
+ Misses      12576   12575     -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot finished reviewing on behalf of bhimrazy December 3, 2025 17:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants