migrate to latest supported pydantic#54
migrate to latest supported pydantic#54Vectorrent wants to merge 10 commits intoLightning-Universe:mainfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==================================
Coverage 86% 86%
==================================
Files 3 3
Lines 167 167
==================================
Hits 144 144
Misses 23 23 🚀 New features to boost your workflow:
|
requirements.txt
Outdated
| hivemind >=1.1.0, <=1.1.10.post2; sys_platform == 'linux' | ||
|
|
||
| pydantic <2.0.0 # fixme: lift when resolved | ||
| hivemind @ git+https://github.com/learning-at-home/hivemind.git@213bff98a62accb91f254e2afdccbf1d69ebdea9 |
There was a problem hiding this comment.
lets wait till this is fully released
There was a problem hiding this comment.
I just pinged a maintainer, and was told we can expect a release by end of week.
There was a problem hiding this comment.
I received this update from Max Ryabinin:
JFYI I'm on this, it looks like PyPI does not allow using Git commits as dependencies, and we have one for Multiaddr at the moment. I'm discussing potential solutions with the team: once this is done, we will have Hivemind 1.1.11
There was a problem hiding this comment.
I know that PyPI restrict only published versions not source or commit...
There was a problem hiding this comment.
Sorry, maintainers aren't moving very quickly.
There was a problem hiding this comment.
We finally got a new version:
https://pypi.org/project/hivemind
It's failing tests though. I'm not really sure why, and don't have time to troubleshoot right now.
2 participants
What does this PR do?
This PR lifts the
pydantic < 2.0restriction. Hivemind was recently updated to support Pydantic v2, and this limitation is no longer necessary.I'm not sure why, but maintainers are not releasing PyPi packages anymore. If you look at the Petals source code, you'll see that they just point to the appropriate commit hash on Github; so, that's what I've done here, as well.
Let me know if you have any questions. Thanks!