This repository was archived by the owner on Jan 20, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
migrate to latest supported pydantic #54
Open
Vectorrent
wants to merge
10
commits into
Lightning-Universe:main
Choose a base branch
from
Vectorrent:pydantic-v2-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5910be3
migrate to latest supported pydantic
Vectorrent 9a24f3c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4c87d8d
fix format
Vectorrent 76e8a30
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ba5f5e6
Merge branch 'main' into pydantic-v2-upgrade
Borda 61885e6
Merge branch 'main' into pydantic-v2-upgrade
Borda 45b5feb
lift hivemind version constraint
Vectorrent 5a653ba
Apply suggestions from code review
Borda 5a7601b
Apply suggestions from code review
Borda 6cc3162
Merge branch 'main' into pydantic-v2-upgrade
Borda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| numpy <2.0 # needed for older Torch | ||
| torch <2.3 # fixme: freeze until AMP compatibility is resolved | ||
| lightning >=2.0.0 | ||
| hivemind >=1.1.0, <=1.1.10.post2; sys_platform == 'linux' | ||
|
|
||
| pydantic <2.0.0 # fixme: lift when resolved | ||
| hivemind @ git+https://github.com/learning-at-home/hivemind.git@213bff98a62accb91f254e2afdccbf1d69ebdea9 | ||
| hivemind >=1.1.0; sys_platform == 'linux' | ||
Borda marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets wait till this is fully released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vectorrent was it released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pinged a maintainer, and was told we can expect a release by end of week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I received this update from Max Ryabinin:
JFYI I'm on this, it looks like PyPI does not allow using Git commits as dependencies, and we have one for Multiaddr at the moment. I'm discussing potential solutions with the team: once this is done, we will have Hivemind 1.1.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that PyPI restrict only published versions not source or commit...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, how it it going?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, maintainers aren't moving very quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We finally got a new version:
https://pypi.org/project/hivemind
It's failing tests though. I'm not really sure why, and don't have time to troubleshoot right now.