Added Firefox signing without explicit id#16
Open
adamhwang wants to merge 3 commits intoLinusU:masterfrom
Open
Added Firefox signing without explicit id#16adamhwang wants to merge 3 commits intoLinusU:masterfrom
adamhwang wants to merge 3 commits intoLinusU:masterfrom
Conversation
|
@LinusU Any news regarding this? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Firefox 48 the "id" property is now optional:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings
Extensions published after FF48 will automatically have its id generated.
web-ext signsupports this through an optional "--id" flag:https://extensionworkshop.com/documentation/develop/getting-started-with-web-ext#packaging-your-extension
This PR adds support to sign and publish Firefox addons without an explicit id in its manifest. Instead, the id can be specified with the env var
WEXT_SHIPIT_FIREFOX_EXTENSION_ID. This further standardizes the way shipit publishes web extensions across browsers and provides the ability to use the same webext for all three supported extension stores.Working example: https://travis-ci.com/adamhwang/ita-matrix-powertools/jobs/288630882