Skip to content

Added Firefox signing without explicit id #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamhwang wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Firefox signing without explicit id #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ab1177
Added Firefox signing without explicit id
adamhwang Feb 18, 2020
ed5dda9
Updated readme
adamhwang Feb 18, 2020
1067d57
Merge branch 'LinusU:master' into master
adamhwang Jun 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/firefox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ module.exports = async function (source) {
'--api-secret', process.env.WEXT_SHIPIT_FIREFOX_JWT_SECRET
]

if (process.env.WEXT_SHIPIT_FIREFOX_EXTENSION_ID) {
args.push('--id');
args.push(process.env.WEXT_SHIPIT_FIREFOX_EXTENSION_ID);
}

const spinner = ora('Loading web-ext tool...').start()

try {
Expand Down
4 changes: 3 additions & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,12 @@ Follow [this guide](https://developer.chrome.com/webstore/using_webstore_api) to

Go to [this site](https://addons.mozilla.org/en-GB/developers/addon/api/key/) and generate API Credentials. It will output "JWT issuer" and "JWT secret".

- `WEXT_SHIPIT_FIREFOX_EXTENSION_ID` - Optional. The id of the extension (can be specified here or in the manifest below)

Make sure that your extension id is specified in your manifest, [like shown here](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings).

### Opera

- `WEXT_SHIPIT_OPERA_EMAIL` - Email address used to log in to addons.opera.com
- `WEXT_SHIPIT_OPERA_EXTENSION_ID` - ID of the extension (can be seen in the url in the developer dashboard)
- `WEXT_SHIPIT_OPERA_EXTENSION_ID` - The id of the extension (can be seen in the url in the developer dashboard)
- `WEXT_SHIPIT_OPERA_PASSWORD` - Password used to log in to addons.opera.com