-
Notifications
You must be signed in to change notification settings - Fork 0
Translations update from JohnRDOrazio Weblate #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (98 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/de/
Currently translated at 14.2% (14 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/hr/
Currently translated at 64.2% (63 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/pl/
WalkthroughThis PR updates PO files for multiple locales (de, hr, pl, es, sk, hu, fr): header metadata (PO-Revision-Date, Last-Translator → John R. D'Orazio or Weblate Admin entries, X-Generator) were changed and numerous translation strings were added, reformatted, or revised; no functional code changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Currently translated at 100.0% (98 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/de/
Currently translated at 100.0% (98 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/es/
Currently translated at 100.0% (98 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/sk/
Currently translated at 64.2% (63 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/pl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
i18n/de/LC_MESSAGES/catholicliturgy.po(3 hunks)i18n/es/LC_MESSAGES/catholicliturgy.po(3 hunks)i18n/pl/LC_MESSAGES/catholicliturgy.po(6 hunks)
🔇 Additional comments (6)
i18n/pl/LC_MESSAGES/catholicliturgy.po (2)
5-5: LGTM! Metadata updates are correct.The translator attribution, revision date, and Weblate generator version updates follow standard PO file conventions and properly reflect the translation workflow.
Also applies to: 11-12, 21-21
333-333: Translation updates look well-formed.The Polish translations for liturgical terms appear grammatically consistent (e.g., proper singular/plural forms for "Pasterze"/"pasterzy") and maintain appropriate case conventions. The updates integrate cleanly with the existing translation file structure.
Also applies to: 403-403, 526-526, 531-531, 546-546
i18n/de/LC_MESSAGES/catholicliturgy.po (2)
5-5: LGTM! Standard Weblate metadata updates.The metadata changes correctly reflect the translation update: updated copyright years, revision date, translator attribution, and Weblate version.
Also applies to: 13-14, 22-22
353-353: Translation terminology updates look reasonable.The changes update liturgical terms:
- "Pastors" → "Hirten" (shepherds, more liturgically appropriate)
- "Optional memorial" → "Freiwilliges Gedächtnis"
- "Memorial" → "Gedächtnis"
These appear to improve liturgical accuracy and terminology consistency. Consider having a German-speaking liturgical expert verify these changes to ensure theological precision.
Also applies to: 546-546, 551-551
i18n/es/LC_MESSAGES/catholicliturgy.po (2)
7-7: LGTM! Standard metadata updates.The metadata updates correctly reflect the new contributor, revision date, translator information, and Weblate version. These are standard PO file maintenance updates.
Also applies to: 13-14, 22-22
129-130: LGTM! Line formatting adjustment.The text has been reformatted with adjusted line breaks and spacing. The actual translation content remains correct and semantically unchanged.
| #: includes/enums/LitGrade.php:98 | ||
| msgid "Optional memorial" | ||
| msgstr "Memoria facultativa" | ||
| msgstr "Memoria opcional" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
official Spanish term "Memoria opcional" Catholic liturgical calendar
💡 Result:
La forma oficial en español es "memoria facultativa" (no "memoria opcional"). [1][2]
Fuentes:
- Texto explicativo sobre la Instrucción General de la Liturgia de las Horas (usa "memoria facultativa"). [1]
- Decreto vaticano y notas sobre la inscripción de celebraciones en el Calendario romano (emplean "memoria facultativa"). [2]
🌐 Web query:
"Memoria facultativa" "Memoria opcional" Catholic liturgy Spanish terminology
💡 Result:
"Memoria facultativa" y "memoria opcional" son términos equivalentes en español para la categoría litúrgica English "optional memorial". Indican una memoria de santo/a que las comunidades pueden celebrar a su criterio (no es obligatoria como una memoria obligatoria, fiesta o solemnidad). Véase explicación y ejemplos en fuentes litúrgicas y noticias sobre el Calendario Romano (uso intercambiable de "memoria facultativa"/"memoria opcional"). [1][2][3]
Fuentes:
- Ejemplos y uso en calendarios y decretos sobre el Calendario Romano (Memoria/«Memoria opcional» para santos añadidos). [1][2]
- Explicación normativa sobre memorias (diferencia entre memorias obligatorias y memorias facultativas/opcionales). [3]
Referencias
[1] APOSTOLADO DE LOS SAGRADOS CORAZONES — ejemplo: «memoria facultativa / Memoria Opcional». (sitio sobre calendario litúrgico). (sagradoscorazonesunidos.org)
[2] Noticias y decretos sobre inserciones en el Calendario Romano (Madre Teresa: «memoria facultativa / memoria opcional»). (elobservadorenlinea.com)
[3] Comentario litúrgico sobre memorias (normas de cuándo son celebrables y su carácter facultativo). (es.zenit.org)
Citations:
- 1: https://sagradoscorazonesunidos.org/el-santo-nombre-de-jesus/?utm_source=openai
- 2: https://elobservadorenlinea.com/2025/02/la-madre-teresa-fue-inscripta-en-el-calendario-romano/?utm_source=openai
- 3: https://es.zenit.org/2025/02/23/preguntas-sobre-liturgia-decidir-que-oficio-rezar/?utm_source=openai
🌐 Web query:
Catholic Church calendar grades Spanish "optional memorial" official term
💡 Result:
The official Spanish term is "memoria facultativa". [1]
Sources:
[1] Dicasterio para el Culto Divino — sitio del Vaticano (anexo: denominación de la memoria facultativa en el Calendario Romano General).
Revert terminology to official Vatican Spanish form.
The translation change from "Memoria facultativa" to "Memoria opcional" moves away from official Catholic liturgical terminology. Vatican sources (Dicasterio para el Culto Divino) and the Instrucción General de la Liturgia de las Horas consistently use "memoria facultativa" as the canonical Spanish term for the "optional memorial" grade of celebration.
While "opcional" may be more colloquially clear, this liturgical content requires adherence to official Vatican terminology for consistency with authoritative Church documents. Revert to "Memoria facultativa."
🤖 Prompt for AI Agents
In i18n/es/LC_MESSAGES/catholicliturgy.po around line 540, the msgstr was
changed to "Memoria opcional" but official Vatican Spanish terminology requires
"Memoria facultativa"; revert the translation at that line to use "Memoria
facultativa" so the text matches Dicasterio para el Culto Divino and the
Instrucción General de la Liturgia de las Horas.
Currently translated at 6.1% (6 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/hu/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
i18n/hu/LC_MESSAGES/catholicliturgy.po (1)
310-312: Verify that “Proprium” is the desired user-facing termMapping “Proper” to the Latin loanword “Proprium” may be exactly what you want in Hungarian liturgical phrasing; if not, consider a fully localized Hungarian equivalent instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
i18n/hu/LC_MESSAGES/catholicliturgy.po(2 hunks)
🔇 Additional comments (1)
i18n/hu/LC_MESSAGES/catholicliturgy.po (1)
5-20: Header metadata updates are consistentTranslator credit, revision date, last-translator, and X-Generator fields are coherent and match a normal Weblate update; nothing to change here.
Currently translated at 100.0% (98 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/de/
Currently translated at 100.0% (98 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/es/
Currently translated at 100.0% (98 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/sk/
Currently translated at 15.3% (15 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/hr/
Currently translated at 100.0% (98 of 98 strings) Translation: Liturgical Calendar/Alexa interactive Translate-URL: https://translate.johnromanodorazio.com/projects/liturgical-calendar/alexa-interactive/fr/
Translations update from JohnRDOrazio Weblate for Liturgical Calendar/Alexa interactive.
Current translation status:
Summary by CodeRabbit
Translations
Chores
✏️ Tip: You can customize this high-level summary in your review settings.