Skip to content

🧩: fix export lookup from frozen modules#1713

Merged
linusha merged 1 commit intomainfrom
fix/exports-lookup-frozen
Feb 24, 2025
Merged

🧩: fix export lookup from frozen modules#1713
linusha merged 1 commit intomainfrom
fix/exports-lookup-frozen

Conversation

@merryman
Copy link
Member

@merryman merryman commented Feb 7, 2025

In fast load, when browsing for modules exporting certain entities, it would display all kinds of matches that would not make any sense. This fixes that.

@merryman merryman requested a review from linusha February 7, 2025 16:03
@linusha
Copy link
Contributor

linusha commented Feb 20, 2025

I might miss something obvious here, but could you remind me of how exactly I could verify that this works as intended?

@merryman merryman force-pushed the fix/exports-lookup-frozen branch from 776bddc to 46c61a5 Compare February 21, 2025 10:51
@merryman
Copy link
Member Author

I think one easy example is if you open a workspace in fastLoad and select "Add Import" from the context menu, you will see a weird __reexport___eval-> entry in the module prompt. That should be gone once you try the same on this branch.

@linusha linusha merged commit 699a678 into main Feb 24, 2025
4 checks passed
@linusha linusha deleted the fix/exports-lookup-frozen branch February 24, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants