-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix: dropscreen with no hardcoded sleep (#4907) #4998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
fix retire assets EN replace sleep for reward screen
LmeSzinc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CampaignBonusStatisticsshould not inheritButtonGridandTimer. It will pollute the entire Alas module- Don't use ocr if you don't need the exact number
- Never use
cv2.imreadandcv2.imwrite. opencv can't handle non-ascii filepath, and so many years passed by they never fixed it.
|
One PR do one thing. Open another PR for the DOCK_AMOUNT thingy |
|
|
I don't really have an idea how to implement it without the OCR, since it is way to dynamic for any other check. If you have an idea pls share @LmeSzinc. Aside from that, adjusted to your other requests; |
small tweaks
55a23c7 to
cb8d66c
Compare
|
Maybe post the debug images you collected, I'll try to find some features. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Crop REWARD_AREA and TITLE_REWARD, TITLE_CLEARING_REWARD using the same image, use a large search area to find the title |
dragonheart107
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had no issues testing the refactor, so should be good to merge after your OK
|
@LmeSzinc could you see if it's okay to merge now? |
replaced the hardcoded sleep with an area change detection, it should work for CN, but might have issues in TW or JP since their base asset used as anchor point is non default for JP and smaller for TW (#4907)
kept debug related parts in for now
additionally 2 asset related fixes for EN, non urgent -> added in this PR:
dock amount: position and size changed, Ocr misdeteced
enhance: alas would never flag it as empty: