Skip to content

fixed bench statements #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2025
Merged

fixed bench statements #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52a6179
fixed bench statements
Malmahrouqi3 Jun 20, 2025
5add2ab
fixed typo
Malmahrouqi3 Jun 20, 2025
441a683
Update bench.yml
sbryngelson Jun 21, 2025
8d99f72
Update bench.yml
sbryngelson Jun 21, 2025
170cbe6
Update bench.yml
sbryngelson Jun 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: 'Benchmark'

on: pull_request
on:
pull_request_review:
types: [submitted]
workflow_dispatch:

jobs:
file-changes:
Expand All @@ -20,11 +23,12 @@ jobs:

self:
name: Georgia Tech | Phoenix (NVHPC)
if: github.repository == 'MFlowCode/MFC' && needs.file-changes.outputs.checkall == 'true'
if: github.repository == 'MFlowCode/MFC' && needs.file-changes.outputs.checkall == 'true' && ${{ github.event.review.state == 'approved' }}
needs: file-changes
strategy:
matrix:
device: ['cpu', 'gpu']
fail-fast: false
runs-on:
group: phoenix
labels: gt
Expand Down Expand Up @@ -56,6 +60,12 @@ jobs:
(cd pr && . ./mfc.sh load -c p -m g)
(cd pr && ./mfc.sh bench_diff ../master/bench-${{ matrix.device }}.yaml ../pr/bench-${{ matrix.device }}.yaml)

- name: Print Logs
if: always()
run: |
cat pr/bench-${{ matrix.device }}.* 2>/dev/null || true
cat master/bench-${{ matrix.device }}.* 2>/dev/null || true

- name: Archive Logs
uses: actions/upload-artifact@v4
if: always()
Expand Down
7 changes: 3 additions & 4 deletions toolchain/mfc/bench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ def diff():
if not math.isfinite(lhs_summary[target.name]["exec"]) or not math.isfinite(rhs_summary[target.name]["exec"]):
err = 1
cons.print(f"lhs_summary or rhs_summary reports non-real exec time for {target.name} - Case: {slug}")

try:
exec_time_value = lhs_summary[target.name]["exec"] / rhs_summary[target.name]["exec"]
if exec_time_value < 0.9:
Expand All @@ -139,10 +138,10 @@ def diff():
grind_time_value = lhs_summary[target.name]["grind"] / rhs_summary[target.name]["grind"]
speedups[i] += f" & Grind: {grind_time_value:.2f}"
if grind_time_value <0.95:
raise MFCException(f"Benchmarking failed since grind time speedup for {target.name} below acceptable threshold (<0.98) - Case: {slug}")
cons.print(f"[bold red]Error[/bold red]: Benchmarking failed since grind time speedup for {target.name} below acceptable threshold (<0.95) - Case: {slug}")
err = 1
except Exception as _:
err = 1
cons.print(f"lhs_summary or rhs_summary reports non-real grind time for {target.name} - Case: {slug}")
pass

table.add_row(f"[magenta]{slug}[/magenta]", *speedups)

Expand Down
Loading