Fix/repart 2d #41
Merged
Fix/repart 2d #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanhhughes
force-pushed
the
fix/repart_2d
branch
from
f35af1a to
d56aea7
Compare
jaredstrader
force-pushed
the
fix/repart_2d
branch
from
66d2f45 to
81e1c5b
Compare
Contributor
Author
|
@nathanhhughes Are you okay if we merge this? I just force-pushed after rebasing onto the latest |
nathanhhughes
approved these changes
May 27, 2025
Collaborator
nathanhhughes
left a comment
nathanhhughes
left a comment
There was a problem hiding this comment.
Yeah, LGTM, good to merge. There's some stuff I want to double check / some visualizations I was working on, but I won't get to it until next week / will do it separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going ahead and creating the PR, but perhaps, we wait to merge until we resolve why there are still a few places not being assigned rooms. Adding @SiyiHu since this is relevant for the scene prediction experiments.