Skip to content

Conversation

@yunzc
Copy link
Member

@yunzc yunzc commented May 25, 2025

For hydra-multi evaluation

@yunzc yunzc requested a review from nathanhhughes May 25, 2025 01:53
Copy link
Collaborator

@nathanhhughes nathanhhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this should work, but probably better to bind the right attr subclass

"ObjectNodeAttributes")
.def(py::init<>())
.def_readwrite("registered", &ObjectNodeAttributes::registered)
.def_readonly("mesh_connections", &KhronosObjectAttributes::mesh_connections)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.def_readonly("mesh_connections", &KhronosObjectAttributes::mesh_connections)
.def_readonly("mesh_connections", &ObjectAttributes::mesh_connections)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh 🤦 sorry this is a careless mistake on my part

@yunzc yunzc merged commit 02e4f1b into develop May 25, 2025
5 checks passed
@yunzc yunzc deleted the feature/pybind_mesh_objs branch May 25, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants