Skip to content

add binding for mesh connections #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yunzc merged 2 commits into from
May 25, 2025
Merged

add binding for mesh connections #45

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a92df4
add binding for mesh connections
yunzc May 25, 2025
4be6323
fix binding to correct class
yunzc May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/bindings/src/spark_dsg_bindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ PYBIND11_MODULE(_dsg_bindings, module) {
"ObjectNodeAttributes")
.def(py::init<>())
.def_readwrite("registered", &ObjectNodeAttributes::registered)
.def_readonly("mesh_connections", &KhronosObjectAttributes::mesh_connections)
Copy link
Collaborator

@nathanhhughes nathanhhughes May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.def_readonly("mesh_connections", &KhronosObjectAttributes::mesh_connections)
.def_readonly("mesh_connections", &ObjectAttributes::mesh_connections)

Copy link
Member Author

@yunzc yunzc May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh 🤦 sorry this is a careless mistake on my part

.def_property(
"world_R_object",
[](const ObjectNodeAttributes& attrs) {
Expand Down