Feature/rename scene graph #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanhhughes
force-pushed
the
feature/rename_scene_graph
branch
from
dd97685 to
1653b14
Compare
Collaborator
Author
|
I'm going to merge to develop for now, we can revert at some point if we want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably a little unnecessary, but I think this makes more sense. It should not break downstream code (there's an alias for both the c++ and python side with the old class name), haven't figured out a non-annoying way to deprecate the
DynamicSceneGraphclass name (on the c++ side you get 50ish warnings when building Hydra)