Skip to content

Add traversability layer name to python bindings#77

Merged
GoldenZephyr merged 1 commit intomainfrom
fix/traversability_binding
Nov 19, 2025
Merged

Add traversability layer name to python bindings#77
GoldenZephyr merged 1 commit intomainfrom
fix/traversability_binding

Conversation

@GoldenZephyr
Copy link
Copy Markdown
Contributor

this is another traversability place binding problem that had been left behind in ROS1

@GoldenZephyr
Copy link
Copy Markdown
Contributor Author

can you remind be the workflow for merging to main vs. develop?

nathanhhughes
nathanhhughes previously approved these changes Nov 17, 2025
Copy link
Copy Markdown
Collaborator

@nathanhhughes nathanhhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanhhughes
Copy link
Copy Markdown
Collaborator

can you remind be the workflow for merging to main vs. develop?

@GoldenZephyr basically what you've done so far is the easiest. Once this is merged, you or I can go and fast-forward merge develop locally to be even with main (the other way, PRing into develop also works but I can't remember if you can push to main or not). I think it'll be easier though once #73 and #76 get merged to develop and then the two branches won't be even

@GoldenZephyr
Copy link
Copy Markdown
Contributor Author

@nathanhhughes Another traversability place Python fix that I thought I would stick in here

@GoldenZephyr
Copy link
Copy Markdown
Contributor Author

@nathanhhughes At some point could you take a quick look at why the tests are unhappy with how I put in the TraversabilityState bindings? The unit tests fail because of the TraversabilityState binding but I have no idea why

@nathanhhughes
Copy link
Copy Markdown
Collaborator

@GoldenZephyr you already ported that one earlier: e1bb5ad

@GoldenZephyr GoldenZephyr force-pushed the fix/traversability_binding branch from 63ed4f1 to be9662d Compare November 19, 2025 00:13
@GoldenZephyr
Copy link
Copy Markdown
Contributor Author

@nathanhhughes fixed, although I think I need you to reapprove

@GoldenZephyr GoldenZephyr merged commit bbd6152 into main Nov 19, 2025
6 checks passed
@nathanhhughes nathanhhughes deleted the fix/traversability_binding branch January 12, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants