Implemented icons in sidebar and callouts in results list #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the old FontAwesome installation * Set icons in markup for callouts and sidebar * Styled size and spacing of icons
Pull Request Test Coverage Report for Build 19584029543Details
💛 - Coveralls |
matt-bernhardt
approved these changes
Nov 24, 2025
Member
matt-bernhardt
left a comment
matt-bernhardt
left a comment
There was a problem hiding this comment.
Yep, this is about as straightforward as you said. Thanks!
| <![endif]--> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/normalize/4.1.1/normalize.min.css"> | ||
| <%= stylesheet_link_tag 'https://use.typekit.net/ixd2vgq.css' %> | ||
| <%= stylesheet_link_tag 'https://cdn.libraries.mit.edu/files/fontawesome/7.1.0/css/all.min.css' %> |
Member
There was a problem hiding this comment.
Hooray for using the CDN as much as we can :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work implements icons using our new FontAwesome Pro 7 installation available via CDN. This work includes:
This work does affect GeoData, but icons still appear after this swap. The only noticeable difference is the new icons have a slightly slimmer weight.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing