Skip to content

[DOP-22579] Return statistics in GET /runs#159

Merged
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22579
Feb 13, 2025
Merged

[DOP-22579] Return statistics in GET /runs#159
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22579

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 12, 2025

Change Summary

Changed the response schema of GET /runs to include inputs, outputs and operations statistics. This is useful to show in list of runs within job, or to hide "Operations" tab at RunShow page.

Don't change response for lineage, as it includes inputs & outputs are distinct relations.

Also I haven't included statistics of child runs because its value depends on since+until range, and calculating the total number of child runs can be expensive as there is no filter against run.created_at which is partitioning column.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Feb 12, 2025
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 98.94737% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.04%. Comparing base (7fa0d2d) to head (56b4e22).
Report is 138 commits behind head on develop.

Files with missing lines Patch % Lines
data_rentgen/server/services/run.py 97.95% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #159      +/-   ##
===========================================
+ Coverage    92.82%   93.04%   +0.22%     
===========================================
  Files          180      182       +2     
  Lines         3956     4115     +159     
  Branches       269      277       +8     
===========================================
+ Hits          3672     3829     +157     
- Misses         222      224       +2     
  Partials        62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus enabled auto-merge (rebase) February 13, 2025 08:23
@dolfinus dolfinus merged commit e2f8346 into develop Feb 13, 2025
11 checks passed
@dolfinus dolfinus deleted the feature/DOP-22579 branch February 13, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants