Skip to content

[DOP-22578] Return statistics in GET /locations#160

Merged
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22578-locations
Feb 13, 2025
Merged

[DOP-22578] Return statistics in GET /locations#160
dolfinus merged 1 commit intodevelopfrom
feature/DOP-22578-locations

Conversation

@dolfinus
Copy link
Member

Change Summary

Changed the response schema of GET /locations and PATCH /locations/:id to include dataset & job statistics. This is useful to show in list of locations, or to show/hide tabs with datasets/jobs list on LocationShow page.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Feb 12, 2025
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.14%. Comparing base (e2f8346) to head (e1d22ca).
Report is 136 commits behind head on develop.

Files with missing lines Patch % Lines
data_rentgen/server/services/location.py 97.87% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #160      +/-   ##
===========================================
+ Coverage    93.04%   93.14%   +0.09%     
===========================================
  Files          182      183       +1     
  Lines         4115     4188      +73     
  Branches       277      281       +4     
===========================================
+ Hits          3829     3901      +72     
- Misses         224      225       +1     
  Partials        62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus force-pushed the feature/DOP-22578-locations branch from 956e2b4 to e1d22ca Compare February 13, 2025 08:27
@dolfinus dolfinus enabled auto-merge (rebase) February 13, 2025 08:27
@dolfinus dolfinus merged commit 5e52684 into develop Feb 13, 2025
11 checks passed
@dolfinus dolfinus deleted the feature/DOP-22578-locations branch February 13, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants