Skip to content

Conversation

@GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Sep 11, 2023

Fixes: #6903 and #6904

Converted user form to React and added Cypress tests for the form.

Before:

Edit Admin User Form:
AdminUserBefore
Add User Form:
AddUserBefore
Edit User Form:
EditUserBefore
Copy User Form:
CopyUserBefore

After:

Edit Admin User Form:
AdminUserAfter
Add User Form:
AddUserAfter
Edit User Form:
EditUserAfter
Copy User Form:
CopyUserAfter

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner September 11, 2023 13:11
@miq-bot miq-bot added the wip label Sep 11, 2023
@GilbertCherrie GilbertCherrie force-pushed the convert_user_form branch 2 times, most recently from a959e72 to ffd13db Compare October 2, 2023 19:51
@GilbertCherrie GilbertCherrie force-pushed the convert_user_form branch 5 times, most recently from 444bd81 to 0b91982 Compare October 6, 2023 15:54
@GilbertCherrie GilbertCherrie mentioned this pull request Oct 24, 2023
15 tasks
@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot miq-bot added the stale label Feb 19, 2024
@GilbertCherrie GilbertCherrie force-pushed the convert_user_form branch 3 times, most recently from f181f47 to 55e116c Compare May 6, 2024 16:43
@kbrock
Copy link
Member

kbrock commented May 9, 2024

as mentioned elsewhere, passing attributes=miq_groups will bring back the groups

@GilbertCherrie GilbertCherrie changed the title [WIP] Convert user form to React Convert user form to React May 27, 2024
@GilbertCherrie GilbertCherrie force-pushed the convert_user_form branch 3 times, most recently from d34575a to 63b757b Compare May 27, 2024 20:13
@miq-bot
Copy link
Member

miq-bot commented Aug 6, 2024

Checked commit GilbertCherrie@d37ccfd with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
7 files checked, 5 offenses detected

app/controllers/ops_controller/ops_rbac.rb

app/views/ops/_rbac_user_details.html.haml

  • ⚠️ - Line 3 - Avoid using instance variables in partials views
  • ⚠️ - Line 4 - Style/RedundantConstantBase: Remove redundant ::.
  • ⚠️ - Line 8 - Avoid using instance variables in partials views
  • ⚠️ - Line 8 - Line is too long. [122/80]

@miq-bot
Copy link
Member

miq-bot commented Nov 11, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Feb 17, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2025

This pull request is not mergeable. Please rebase and repush.

@kbrock
Copy link
Member

kbrock commented Oct 27, 2025

Yay. can @elsamaryv merge, or do you need someone else to pull the trigger?

@GilbertCherrie
Copy link
Member Author

@kbrock I don't think Elsa has merge rights, but also although this pr should be good I was hoping @asirvadAbrahamVarghese can fix the cypress specs first before merging

@asirvadAbrahamVarghese
Copy link
Contributor

Let’s try this out: GilbertCherrie#1

@asirvadAbrahamVarghese
Copy link
Contributor

Regarding the Cypress failures, we’re currently seeing two main causes:

  1. Due to the session write issue
image

PR: #9533

  1. selectAccordionItem command not finding nodes because the list is still loading
image

PR: #9713

Once both PRs are merged, lets re-run the test to confirm if this resolves the failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form conversion: Configuration Acces Control/Users/Configuration/Add a new user

6 participants