-
Notifications
You must be signed in to change notification settings - Fork 366
Convert user form to React #8916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2ae26b7 to
4a1034b
Compare
a959e72 to
ffd13db
Compare
444bd81 to
0b91982
Compare
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
f181f47 to
55e116c
Compare
|
as mentioned elsewhere, passing |
d34575a to
63b757b
Compare
7c4c163 to
d37ccfd
Compare
|
Checked commit GilbertCherrie@d37ccfd with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/controllers/ops_controller/ops_rbac.rb
app/views/ops/_rbac_user_details.html.haml |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
1 similar comment
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
d37ccfd to
6335671
Compare
|
This pull request is not mergeable. Please rebase and repush. |
6335671 to
d49dcce
Compare
d49dcce to
0cdfa47
Compare
|
Yay. can @elsamaryv merge, or do you need someone else to pull the trigger? |
|
@kbrock I don't think Elsa has merge rights, but also although this pr should be good I was hoping @asirvadAbrahamVarghese can fix the cypress specs first before merging |
|
Let’s try this out: GilbertCherrie#1 |
a77e581 to
cd3a66e
Compare
cd3a66e to
2a03fb0
Compare


Fixes: #6903 and #6904
Converted user form to React and added Cypress tests for the form.
Before:
Edit Admin User Form:




Add User Form:
Edit User Form:
Copy User Form:
After:
Edit Admin User Form:




Add User Form:
Edit User Form:
Copy User Form: