Enhanced selectAccordionItem to wait for items to load before proceeding #9713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asirvadAbrahamVarghese
force-pushed
the
enhance-select-accordion-item
branch
from
0ab1a78 to
29c406c
Compare
| cy.get('div.panel-collapse.collapse.in').then((freshAccordion) => { | ||
| cy.wrap(freshAccordion) | ||
| .find('li.list-group-item') | ||
| .should('have.length.greaterThan', 0) |
Contributor
Author
There was a problem hiding this comment.
This causes Cypress to retry the .find() command until this assertion passes for a minimum time (4Sec here)
| }); | ||
|
|
||
| cy.get('div.panel-collapse.collapse.in').then((freshAccordion) => { | ||
| cy.wrap(freshAccordion) |
Contributor
Author
There was a problem hiding this comment.
Even though freshAccordion was captured once, when we do cy.wrap(freshAccordion).find(), jQuery's .find() method queries the current state of the DOM tree under that element, not a snapshot because jQuery maintains a reference to the DOM elements.
Note: We could also query the whole accordion repeatedly here, but since this approach seems to work, let’s stick with it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced the
selectAccordionItemcommand to wait for list items to load prior to initiating the lookupThis issue was noticed as part of #8916 where it failed to find
linodes when there is a delay:Fix: re-query the dom when no
linodes are found initially:@miq-bot add-label cypress
@miq-bot add-label refactoring
@miq-bot assign @jrafanie