-
Notifications
You must be signed in to change notification settings - Fork 27
MDBF-1078 Ubuntu 20.04 is EOL #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
grooverdan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good. Guess we'll see who the eco-php goes.
Could remove 10.5 out of the gridview.
maps to what I was planning on the Docker Official Images side - MariaDB/mariadb-docker#553
|
MariaDB/mariadb-docker#645 for merging at the same time as the CI starts triggering the docker-library worker from jammy. |
So when this patch reaches buildbot production, right? |
yes. BB production. |
No need to rush the on the MariaDB/mariadb-docker#645 merge. It will only impact 10.6 pushes which don't happen too often. @fauust and @vl-radu have push rights there when needed (and actually all server developers - which I may reconsider at some stage soon). |
This patch is targeted for buildbot release v1.0.7 I know I had an attempt to cover it in MariaDB#756 but I don't like getting merge conflicts on constants.py. so it's better to separate the concerns a bit, remove 10.5 and then handle any platform deprecation / addition.
This patch is targeted for buildbot release v1.0.7 I know I had an attempt to cover it in MariaDB#756 but I don't like getting merge conflicts on constants.py. so it's better to separate the concerns a bit, remove 10.5 and then handle any platform deprecation / addition.
This patch is targeted for buildbot release v1.0.7 I know I had an attempt to cover it in MariaDB#756 but I don't like getting merge conflicts on constants.py. so it's better to separate the concerns a bit, remove 10.5 and then handle any platform deprecation / addition.
This patch is targeted for buildbot release v1.0.7 I know I had an attempt to cover it in MariaDB#756 but I don't like getting merge conflicts on constants.py. so it's better to separate the concerns a bit, remove 10.5 and then handle any platform deprecation / addition.
This patch is targeted for buildbot release v1.0.7 I know I had an attempt to cover it in MariaDB#756 but I don't like getting merge conflicts on constants.py. so it's better to separate the concerns a bit, remove 10.5 and then handle any platform deprecation / addition.
This patch is targeted for buildbot release v1.0.7 I know I had an attempt to cover it in #756 but I don't like getting merge conflicts on constants.py. so it's better to separate the concerns a bit, remove 10.5 and then handle any platform deprecation / addition.
5cb7a57 to
2154696
Compare
|
@grooverdan this patch is ready for your final review. How to test c468a36 Note: maybe you know better why is this happening: |
|
you could Alternately I had a play with using compose to make run tests against released php which might be sufficient - grooverdan@ce2b326#diff-bbcfeb8a42b67e1105356482e81736e01cddecce7e3fe6bf13bd9f1fa02ad15c happy to move the latest php branch build with MariaDB to a new project ( running in PHP's github actions?) if you want to package the compose /pod test runs like wordpress and just use released versions. Test exclusions have got a bit out of date. The early PHP version is based on https://mariadb.org/post-mortem-php-and-mariadb-docker-issue/ and with the container the php-7.1 can still work. |
I see PHP folks use Circle CI to perform integration tests with MySQL / PostgreSQL. A possible course of action can be:
I don't know if this approach is any better. What do you say? |
Additionally, the PHP builder is triggered by the ubuntu2004 builder, About PHP 7.1. -> I get the same as in php/php-src#11810 php 7.4, last in the 7.x series, is EOL since 2022. I think it's time to discard the 7.x series? |
|
happy to remove the php builder altogether and rework it in to external CI in some form. |
Perfect! |
c468a36 to
47db09f
Compare
1. Remove the release builders
2. Docker Library - 10.6 on 2204
3. Upgrade dependent builders:
- Bump Ubuntu to 22.04 for integration testing builders: `eco-php`
- Bump Ubuntu to 22.04 for special builders: debug, big-test, full-test
Make sure to remove amd64-ubuntu-2004-debug from branch protection and add 2204 instead.
- fixed runtime deps for mariadb in ubuntu 22.04 container - fixed build-time deps for php in 22.04 container PHP 7.1 won't compile on 22.04 container but it's EOL anyway. - updated the list with only supported versions. See: https://www.php.net/supported-versions
47db09f to
f1169ee
Compare
f1169ee to
a4e7e68
Compare
bump ubuntu to 22.04 for integration testing builders: eco-phpremoved, needs re-workwithout server (ppc)- Solved in 6b2936510.5 is no longer supported, start SUPPORTED_PLATFORMS from 10.6- Solved in #765