Fix CancellationTokenSource usage so it gets disposed properly in Blazor.WebAssembly project #4714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CancellationTokenSource usage so it gets disposed properly Fixes #4611
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory leak issue in the Blazor WebAssembly project by properly disposing CancellationTokenSource instances and enables access to CSLA internals.
- Adds InternalsVisibleTo attribute for Csla.Blazor.WebAssembly project
- Replaces GetCancellationToken method with proper using statements for CancellationTokenSource disposal
- Removes unused GetCancellationToken helper method
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Source/Csla/Properties/AssemblyInfo.cs | Adds InternalsVisibleTo attribute to expose CSLA internals to Blazor.WebAssembly |
| Source/Csla.Blazor.WebAssembly/State/SessionManager.cs | Fixes CancellationTokenSource disposal by using 'using' statements and removes helper method |
| @@ -56,7 +56,8 @@ public async Task<Session> RetrieveSession(TimeSpan timeout) | |||
| { | |||
| try | |||
| { | |||
| return await RetrieveSession(GetCancellationToken(timeout)); | |||
| using var cts = timeout.ToCancellationTokenSource(); | |||
There was a problem hiding this comment.
The method ToCancellationTokenSource() appears to be an extension method that may not exist in the standard .NET libraries. Ensure this extension method is properly implemented and available, or consider using new CancellationTokenSource(timeout) directly.
Suggested change
| using var cts = timeout.ToCancellationTokenSource(); | |
| using var cts = new CancellationTokenSource(timeout); |
Copilot uses AI. Check for mistakes.
rockfordlhotka
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make internals from csla visible to Blazor.WebAssembly.
Fix CancellationTokenSource usage so it gets disposed properly.
Fixes #4611