fix(deps): 🐛 move electron to optionalDependencies for build compatibility#4
Merged
fix(deps): 🐛 move electron to optionalDependencies for build compatibility#4
Conversation
…ility Move electron from dependencies to optionalDependencies to resolve electron-builder error while maintaining npx execution capability. Co-Authored-By: Claude <noreply@anthropic.com>
Add --no-merges flag to git log to skip auto-generated merge commits from GitHub that don't follow conventional commit format. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
electronfromdependenciestooptionalDependenciesto resolve electron-builder errornpx markpdfdownexecution capability since npm still installs optional dependenciesProblem
electron-builder requires
electronto be indevDependenciesonly, but CLI execution vianpxneeds electron available at runtime.Solution
Using
optionalDependenciessatisfies both requirements:dependencies(notoptionalDependencies)npm installstill installs packages fromoptionalDependenciesTest plan
npm run build:win/build:mac/build:linuxsucceedsnpx markpdfdownstill works correctly🤖 Generated with Claude Code