Skip to content

fix(deps): 🐛 move electron to optionalDependencies for build compatibility #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorben merged 2 commits into from
Jan 25, 2026
Merged

fix(deps): 🐛 move electron to optionalDependencies for build compatibility #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e3cf8e
fix(deps): 🐛 move electron to optionalDependencies for build compatib…
jorben Jan 25, 2026
f3891a4
ci: 🐛 exclude merge commits from commit message validation
jorben Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ jobs:
- name: Validate commit message
run: |
# Get commit message(s) to validate
# Use --no-merges to exclude merge commits (auto-generated by GitHub)
if [ "${{ github.event_name }}" = "pull_request" ]; then
COMMITS=$(git log --format=%s origin/${{ github.base_ref }}..HEAD)
COMMITS=$(git log --no-merges --format=%s origin/${{ github.base_ref }}..HEAD)
else
COMMITS=$(git log -1 --format=%s)
fi
Expand Down
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "markpdfdown",
"version": "0.1.3-tfive",
"version": "0.1.5-tone",
"description": "A high-quality PDF to Markdown tool based on large language model visual recognition.",
"author": "MarkPDFdown",
"main": "dist/main/index.js",
Expand Down Expand Up @@ -103,11 +103,13 @@
"prettier --write"
]
},
"optionalDependencies": {
"electron": "^35.0.2"
},
"dependencies": {
"@ant-design/icons": "^5.6.1",
"@prisma/client": "^6.5.0",
"prisma": "^6.5.0",
"electron": "^35.0.2",
"@types/sharp": "^0.31.1",
"antd": "^5.24.4",
"electron-is-dev": "^3.0.1",
Expand Down
Loading