Update the Status column in the instructor Assignments page#7553
Update the Status column in the instructor Assignments page#7553freyazjiner wants to merge 9 commits intoMarkUsProject:masterfrom
Conversation
Pull Request Test Coverage Report for Build 15418219717Details
💛 - Coveralls |
david-yz-liu
left a comment
david-yz-liu
left a comment
There was a problem hiding this comment.
@freyazjiner nice work. You did what I asked you to do, but I'm adding onto this task to change the name "Summary" to "Grades" in a bunch of the views. Note: you don't need to change any of the routes or back-end method names, this is entirely a front-end addition.
| num_zeros: Number of zeros | ||
| remark_requests_completed: Remark requests completed | ||
| standard_deviation: Standard deviation | ||
| summary_assignment: Assignment Summary |
There was a problem hiding this comment.
Overall this change is good, but I'd prefer a different name than "Assignment Summary".
Let's add a new key under assignments (modify the assignments view yml file) called grades, with value "Grades". Then, display that here (instead of "Assignment Summary") as well as the sub tab where "Summary" currently is shown. You'll need to do some more digging to find where that tab is implemented in the codebase.
Finally, make a pull request to the Wiki repo to modify this page to refer to the "Grades" tab rather than the "Summary" tab. This includes changing the name of the file itself! Note that this introduces you to a second repository for MarkUs: you'll need to repeat the steps you took for setting up the initial MarkUs repository, but with the Wiki repository instead.
updates: - [github.com/thibaudcolas/pre-commit-stylelint: v16.19.1 → v16.20.0](thibaudcolas/pre-commit-stylelint@v16.19.1...v16.20.0) - [github.com/rubocop/rubocop: v1.75.5 → v1.75.8](rubocop/rubocop@v1.75.5...v1.75.8) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps [webmock](https://github.com/bblimke/webmock) from 3.24.0 to 3.25.1. - [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md) - [Commits](bblimke/webmock@v3.24.0...v3.25.1) --- updated-dependencies: - dependency-name: webmock dependency-version: 3.25.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1. Changed from "Assignment <short identifier>" to "<short identifier>: <description>".
2. Changed text in "Policies" section to be written in second-person ("You must complete this assignment individually.").
3. Make "Required Files" only show when there are files needed.
4. Moved "Starter Files" subsection to immediately above the "Submissions" subsection.
5. Modified title so "Files" in "Starter Files" is not capitalised.
6. Added period to the end of first line in starter files.
7. Moved to make "<X> files submitted" the first bullet point in "Submissions" and made it link to the "Submissions" tab.
4 participants
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Delete the "class average", "class median", and "# annotations per marked submission" entries in the "Status" column
in the instructor Assignments page, and replace it with a link to the assignment summary page.
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)
Removing the average_annotations key causes the GitHub test to fail due to an unused I18n key; Since it will be used once Steven adds it to the assignment summary page, and then the test will pass, so I will keep the key for now.