Skip to content

Update the Status column in the instructor Assignments page #7553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
freyazjiner wants to merge 9 commits into from
Closed

Update the Status column in the instructor Assignments page #7553

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9febcba
update the Status column in the instructor Assignments page
freyazjiner Jun 1, 2025
25b4854
update Changelog.md
freyazjiner Jun 1, 2025
7779e3b
update Changelog.md
freyazjiner Jun 1, 2025
d9b07d7
remove unused I18n key
freyazjiner Jun 3, 2025
e763be2
change the label to Grades
freyazjiner Jun 6, 2025
b6dd093
[pre-commit.ci] pre-commit autoupdate (#7554)
pre-commit-ci[bot] Jun 4, 2025
2e445cd
build(deps-dev): bump webmock from 3.24.0 to 3.25.1 (#7552)
dependabot[bot] Jun 4, 2025
a5b290c
Improved assignment view for students (#7533)
chickenwaddle77 Jun 6, 2025
b545e4f
update Changelog.md
freyazjiner Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

### ✨ New features and improvements
- Improved layout and labeling in the assignment settings form for both standard and timed assessments. (#7531)
- Replaced assignment summary statistics in the "Status" column on the instructor Assignments page with a link to the assignment summary page. (#7553)

### 🐛 Bug fixes

Expand Down
18 changes: 2 additions & 16 deletions app/views/assignments/_list_manage.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,6 @@
browse_course_assignment_submissions_path(@current_course, assignment) %>
</span>
<% end %>
<% unless assignment.results_average.nil? %>
<br>
<span>
<%= "#{t(:class_average)}: #{number_to_percentage(assignment.results_average, precision: 1)}" %>
</span>
<% end %>
<% unless assignment.results_median.nil? %>
<br>
<span>
<%= "#{t(:class_median)}: #{number_to_percentage(assignment.results_median, precision: 1)}" %>
</span>
<% end %>
<% if assignment.submission_rule.can_collect_all_now? %>
<% ta_id = @current_role.instructor? ? nil : @current_role.id %>
<br>
Expand All @@ -59,10 +47,8 @@
num_assigned: assignment.get_num_assigned(ta_id)) %>
</span>
<br>
<span>
<%= t('assignments.average_annotations',
average_annotations: assignment.average_annotations(ta_id)) %>
</span>
<%= link_to t('summary_assignment'),
summary_course_assignment_path(course_id: assignment.course_id, id: assignment.id) %>
<% end %>
</td>
</tr>
Expand Down
1 change: 0 additions & 1 deletion config/locales/views/assignments/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
en:
assignments:
assignment_has_groupings: Assignment has groupings.
average_annotations: "%{average_annotations} annotations per marked submission"
configuration_zip_file: Configuration Zip File
deadline_with_extension: You have an extension until %{extension_deadline}.
deletion_confirmation: Are you sure you want to delete this assignment?
Expand Down
1 change: 1 addition & 0 deletions config/locales/views/statistics/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@ en:
num_zeros: Number of zeros
remark_requests_completed: Remark requests completed
standard_deviation: Standard deviation
summary_assignment: Assignment Summary
Copy link
Copy Markdown
Collaborator

@david-yz-liu david-yz-liu Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this change is good, but I'd prefer a different name than "Assignment Summary".

Let's add a new key under assignments (modify the assignments view yml file) called grades, with value "Grades". Then, display that here (instead of "Assignment Summary") as well as the sub tab where "Summary" currently is shown. You'll need to do some more digging to find where that tab is implemented in the codebase.

Finally, make a pull request to the Wiki repo to modify this page to refer to the "Grades" tab rather than the "Summary" tab. This includes changing the name of the file itself! Note that this introduces you to a second repository for MarkUs: you'll need to repeat the steps you took for setting up the initial MarkUs repository, but with the Wiki repository instead.

summary_statistics: Summary Statistics
summary_table: Summary Table