Remove varchar_to_text from MIR#27029
Draft
ggevay wants to merge 4 commits intoMaterializeInc:mainfrom
Draft
Conversation
c215024 to
1c8af88
Compare
0aeb1d8 to
0831f60
Compare
0831f60 to
5157d8e
Compare
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt on https://github.com/MaterializeInc/database-issues/issues/1291 as discussed here, at least for the
varchar_to_textcase.Draft for now, because I'd like to run a full CI first.
In the meantime, there is a relevant design doc PR from Michael: #27239, where this PR is the
eq-typealternative.Edit: A problem is that the adapter crate also calls MIR's typ in several places, to get
RelationDesc's. We'd need to do something about these before merging the PR. A possible solution would be to get the scalar types from the HIR expression instead. This would have sometimes better or worse nullability than MIR's typ, but it being more stable than MIR's typ would probably be an advantage anyway, regardless of this PR.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.