Downgrade EQProp-ColumnKnowledge soft_assert #30765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
soft_assert_or_logthat signals whenColumnKnowledgedoes work afterEquivalencePropagationhas been unexpectedly happening a lot in CI. We have enough examples to start fixing the issue, and we don't want to keep CI flaky while we do so. Therefore, this PR downgrades this assert to just atracing::error!. This way, it won't fail CI, but it will still emit a Sentry error when it happens on staging or production.Additionally, the PR also:
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.