Skip to content

Downgrade EQProp-ColumnKnowledge soft_assert #30765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggevay merged 2 commits into from
Dec 8, 2024
Merged

Downgrade EQProp-ColumnKnowledge soft_assert #30765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25fe42
Downgrade EQProp-ColumnKnowledge soft_assert
ggevay Dec 8, 2024
a9f4674
ci: Reenable two disabled tests
def- Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ci/nightly/pipeline.template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,7 +1191,6 @@ steps:
timeout_in_minutes: 58
agents:
queue: hetzner-aarch64-4cpu-8gb
skip: "flaky until database-issues#8797 is fixed"
plugins:
- ./ci/plugins/mzcompose:
composition: feature-flag-consistency
Expand Down Expand Up @@ -1219,7 +1218,6 @@ steps:
timeout_in_minutes: 60
agents:
queue: hetzner-aarch64-4cpu-8gb
skip: "flaky until database-issues#8797 is fixed"
plugins:
- ./ci/plugins/mzcompose:
composition: sqlsmith
Expand Down
15 changes: 10 additions & 5 deletions src/transform/src/equivalence_propagation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,21 @@ impl crate::Transform for EquivalencePropagation {
&mut get_equivalences,
);

// Trace the plan as the result of `equivalence_propagation` before potentially applying
// `ColumnKnowledge`. (If `ColumnKnowledge` runs, it will trace its own result.)
mz_repr::explain::trace_plan(&*relation);

if prior == *relation {
let ck = crate::ColumnKnowledge::default();
ck.transform(relation, ctx)?;
mz_ore::soft_assert_or_log!(
prior == *relation,
"ColumnKnowledge performed work after EquivalencePropagation"
);
if prior != *relation {
tracing::error!(
?ctx.global_id,
"ColumnKnowledge performed work after EquivalencePropagation",
);
}
}

mz_repr::explain::trace_plan(&*relation);
Ok(())
}
}
Expand Down
Loading