terraform tests: Set default replication factors#31502
Merged
def- merged 1 commit intoMaterializeInc:mainfrom Feb 14, 2025
Merged
terraform tests: Set default replication factors#31502def- merged 1 commit intoMaterializeInc:mainfrom
def- merged 1 commit intoMaterializeInc:mainfrom
Conversation
SangJunBak
approved these changes
Feb 14, 2025
Contributor
SangJunBak
left a comment
SangJunBak
left a comment
There was a problem hiding this comment.
Small requests but otw lgtm!
Comment on lines
+29
to
+32
| system = 1 | ||
| probe = 1 | ||
| support = 1 | ||
| analytics = 1 |
Contributor
There was a problem hiding this comment.
I think the expected defaults should be
system = 0
probe = 0
support = 0
analytics = 0
Contributor
Author
There was a problem hiding this comment.
But the tests expect these clusters to have replicas and be responsive, I'm seeing test failures otherwise, and would prefer not to exclude more tests.
def-
added
the
self-managed-backport-v25.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #31452. Some testdrive tests require these clusters to be usable.
Seen failing in https://buildkite.com/materialize/nightly/builds/11143#019501e1-d68b-407e-8801-4a60b5a18f5d
Green test run: https://buildkite.com/materialize/nightly/builds/11151
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.