Skip to content

terraform tests: Set default replication factors #31502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
def- merged 1 commit into from
Feb 14, 2025
Merged

terraform tests: Set default replication factors #31502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/terraform/aws-persistent/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@ module "materialize_infrastructure" {
environment = "dev"
install_materialize_operator = true

helm_values = {
defaultReplicationFactor = {
system = 1
probe = 1
support = 1
analytics = 1
Comment on lines +29 to +32
Copy link
Contributor

@SangJunBak SangJunBak Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the expected defaults should be

system = 0
probe = 0
support = 0
analytics = 0

Copy link
Contributor Author

@def- def- Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the tests expect these clusters to have replicas and be responsive, I'm seeing test failures otherwise, and would prefer not to exclude more tests.

Copy link
Contributor

@SangJunBak SangJunBak Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh that makes sense!

}
}

# VPC Configuration
vpc_cidr = "10.0.0.0/16"
availability_zones = ["us-east-1a", "us-east-1b"]
Expand Down
9 changes: 9 additions & 0 deletions test/terraform/aws-temporary/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,15 @@ module "materialize_infrastructure" {
environment = "dev"
install_materialize_operator = true

helm_values = {
defaultReplicationFactor = {
system = 1
probe = 1
support = 1
analytics = 1
}
}

# VPC Configuration
vpc_cidr = "10.0.0.0/16"
availability_zones = ["us-east-1a", "us-east-1b"]
Expand Down
9 changes: 9 additions & 0 deletions test/terraform/gcp-temporary/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ module "materialize" {
}

install_materialize_operator = true

helm_values = {
defaultReplicationFactor = {
system = 1
probe = 1
support = 1
analytics = 1
}
}
}

variable "project_id" {
Expand Down