storage: allow sinks on multi-replica clusters#32066
Merged
petrosagg merged 2 commits intoMaterializeInc:mainfrom Apr 2, 2025
Merged
storage: allow sinks on multi-replica clusters#32066petrosagg merged 2 commits intoMaterializeInc:mainfrom
petrosagg merged 2 commits intoMaterializeInc:mainfrom
Conversation
This PR extends the approach of MaterializeInc#31890 to the case of sinks. The handling is identical to that of single replica sources. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg
force-pushed
the
multi-replica-sinks
branch
from
123aec3 to
699cfdf
Compare
ParkMyCar
approved these changes
Apr 1, 2025
Contributor
ParkMyCar
left a comment
ParkMyCar
left a comment
There was a problem hiding this comment.
Maybe get a second look at the storage-controller bits, but as far as I understand how the controller works, it all LGTM!
| @@ -411,12 +473,17 @@ where | |||
| /// | |||
| /// If `send_commands` is true, will send commands for newly-scheduled | |||
Contributor
There was a problem hiding this comment.
This doc comment only references ingestions, it would be nice to update it to all talk about exports. Specifically I'm thinking a description of how a Kafka ingestion is multi-replica, but a Kafka export is single-replica
Contributor
Author
There was a problem hiding this comment.
Good catch, wlll fix
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the approach of
#31890 to the case of sinks. The handling is identical to that of single replica sources.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.