Skip to content

storage: allow sinks on multi-replica clusters #32066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petrosagg merged 2 commits into from
Apr 2, 2025
Merged

storage: allow sinks on multi-replica clusters #32066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
699cfdf
storage: allow sinks on multi-replica clusters
petrosagg Apr 1, 2025
75ced46
update documentation
petrosagg Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/adapter/src/coord/sequencer/inner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1311,14 +1311,6 @@ impl Coordinator {
let (item_id, global_id) =
return_if_err!(self.catalog_mut().allocate_user_id(id_ts).await, ctx);

if let Some(cluster) = self.catalog().try_get_cluster(in_cluster) {
mz_ore::soft_assert_or_log!(
cluster.replica_ids().len() <= 1,
"cannot create sink in cluster {}; has >1 replicas",
cluster.id()
);
}

let catalog_sink = Sink {
create_sql: sink.create_sql,
global_id,
Expand Down
33 changes: 13 additions & 20 deletions src/sql/src/plan/statement/ddl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3416,9 +3416,6 @@ fn plan_sink(
// `in_cluster` value we plan to normalize when we canonicalize the create
// statement.
let in_cluster = source_sink_cluster_config(scx, &mut stmt.in_cluster)?;
if in_cluster.replica_ids().len() > 1 {
sql_bail!("cannot create sink in cluster with more than one replica")
}
let create_sql = normalize::create_statement(scx, Statement::CreateSink(stmt))?;

Ok(Plan::CreateSink(CreateSinkPlan {
Expand Down Expand Up @@ -5317,23 +5314,19 @@ fn plan_drop_network_policy(
/// Returns `true` if the cluster has any object that requires a single replica.
/// Returns `false` if the cluster has no objects.
fn contains_single_replica_objects(scx: &StatementContext, cluster: &dyn CatalogCluster) -> bool {
cluster.bound_objects().iter().any(|id| {
let item = scx.catalog.get_item(id);
let single_replica_source = match item.source_desc() {
Ok(Some(desc)) => match desc.connection {
GenericSourceConnection::Kafka(_)
| GenericSourceConnection::LoadGenerator(_)
| GenericSourceConnection::MySql(_)
| GenericSourceConnection::Postgres(_) => {
let enable_multi_replica_sources =
ENABLE_MULTI_REPLICA_SOURCES.get(scx.catalog.system_vars().dyncfgs());
!enable_multi_replica_sources
}
},
_ => false,
};
single_replica_source || matches!(item.item_type(), CatalogItemType::Sink)
})
// If this feature is enabled then all objects support multiple-replicas
if ENABLE_MULTI_REPLICA_SOURCES.get(scx.catalog.system_vars().dyncfgs()) {
false
} else {
// Othewise we check for the existence of sources or sinks
cluster.bound_objects().iter().any(|id| {
let item = scx.catalog.get_item(id);
matches!(
item.item_type(),
CatalogItemType::Sink | CatalogItemType::Source
)
})
}
}

fn plan_drop_cluster_replica(
Expand Down
Loading