Skip to content

Coordinator: spawn async task for expensive hash work #34349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −9
Open

Coordinator: spawn async task for expensive hash work #34349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/adapter/src/coord/command_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,15 +544,17 @@ impl Coordinator {
}
if let Some(auth) = self.catalog().try_get_role_auth_by_id(&role.id) {
if let Some(hash) = &auth.password_hash {
let _ = match mz_auth::hash::scram256_verify(&password, hash) {
Ok(_) => tx.send(Ok(AuthResponse {
role_id: role.id,
superuser: role.attributes.superuser.unwrap_or(false),
})),
Err(_) => tx.send(Err(AdapterError::AuthenticationError(
AuthenticationError::InvalidCredentials,
))),
};
let hash = hash.clone();
let role_id = role.id;
let superuser = role.attributes.superuser.unwrap_or(false);
task::spawn(|| "auth-check-hash", async move {
Copy link
Contributor

@SangJunBak SangJunBak Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how results look if we use spawn_blocking instead?

let _ = match mz_auth::hash::scram256_verify(&password, &hash) {
Ok(_) => tx.send(Ok(AuthResponse { role_id, superuser })),
Err(_) => tx.send(Err(AdapterError::AuthenticationError(
AuthenticationError::InvalidCredentials,
))),
};
});
return;
}
}
Expand Down