chg: Hide handler variable name in utils.stripProxyFromErrors#18
Merged
Mattwmaster58 merged 1 commit intoMattwmaster58:mainfrom Jul 24, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very weak change, as it doesn't solve the fact that the stack contains at least one extra entry, but it avoids being detected by this specific call during test_pdfStyle.
As far as I can tell, in that specific case, the stack isn't cleaned up, and the script specifically looks for newHandler as a variable name. Using a random name and storing it in
windowit probably a JS crime, but it is slightly less obvious.