Skip to content

chg: Hide handler variable name in utils.stripProxyFromErrors #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mattwmaster58 merged 1 commit into from
Jul 24, 2025
Merged

chg: Hide handler variable name in utils.stripProxyFromErrors #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions playwright_stealth/js/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ const utils = {};
* @param {object} handler - The JS Proxy handler to wrap
*/
utils.stripProxyFromErrors = (handler = {}) => {
const newHandler = {};
let handler_name = (Math.random() + 1).toString(36).substring(15);
window[handler_name] = {}
// We wrap each trap in the handler in a try/catch and modify the error stack if they throw
const traps = Object.getOwnPropertyNames(handler);
traps.forEach((trap) => {
newHandler[trap] = function () {
window[handler_name][trap] = function () {
try {
// Forward the call to the defined proxy handler
return handler[trap].apply(this, arguments || []);
Expand All @@ -34,7 +35,7 @@ utils.stripProxyFromErrors = (handler = {}) => {
const blacklist = [
`at Reflect.${trap} `, // e.g. Reflect.get or Reflect.apply
`at Object.${trap} `, // e.g. Object.get or Object.apply
`at Object.newHandler.<computed> [as ${trap}] `, // caused by this very wrapper :-)
`at window.<computed>.<computed> [as ${trap}] `, // caused by this very wrapper :-)
];
return (
err.stack
Expand All @@ -49,7 +50,7 @@ utils.stripProxyFromErrors = (handler = {}) => {

const stripWithAnchor = (stack) => {
const stackArr = stack.split("\n");
const anchor = `at Object.newHandler.<computed> [as ${trap}] `; // Known first Proxy line in chromium
const anchor = `at window.<computed>.<computed> [as ${trap}] `; // Known first Proxy line in chromium
const anchorIndex = stackArr.findIndex((line) => line.trim().startsWith(anchor));
if (anchorIndex === -1) {
return false; // 404, anchor not found
Expand All @@ -67,7 +68,7 @@ utils.stripProxyFromErrors = (handler = {}) => {
}
};
});
return newHandler;
return window[handler_name];
};

/**
Expand Down
Loading