[3.6 Backport] Add basic handshake defragmentation tests in ssl-opt #10016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests uses openssl s_server with a mix of max_send_frag and split_send_frag options. Signed-off-by: Waleed Elmelegy <[email protected]>
* Add tests for the server side. * Remove restriction for TLS 1.2 so that we can test TLS 1.2 & 1.3. * Use latest version of openSSL to make sure -max_send_frag & -split_send_frag flags are supported. Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
…entation tests Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
Signed-off-by: Waleed Elmelegy <[email protected]>
…on tests. Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
… HS deframentation tests. Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
6 tasks
gilles-peskine-arm
requested changes
Feb 27, 2025
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
4834826 is a faithful backport of #9989 at d01ac30, with a spurious dependency. Otherwise LGTM.
| -C "waiting for more fragments" | ||
|
|
||
| requires_config_enabled MBEDTLS_SSL_PROTO_TLS1_3 | ||
| requires_certificate_authentication |
Contributor
There was a problem hiding this comment.
Why no dependency on ECDSA here?
Contributor
Author
There was a problem hiding this comment.
I commented on the same quesiton on the development #9989 (comment)
In short its not needed.
Contributor
There was a problem hiding this comment.
#9989 (comment) doesn't apply to 3.6, which has RSA-DHE.
So what in our test coverage makes something needed in development but not in 3.6?
Contributor
There was a problem hiding this comment.
That's not really clear to me either. I can see that it passes but I don't really understand why it's needed in development but not 3.6.
Considering we really want to merge this soon, and the thing we don't understand is just the details of a dependency declaration (and possibly some corner case in our complex and underdocumented autodetection logic), I'm OK approving without understanding this specific point, as an exception.
But I'd really like us to get to the bottom of this at some point.
Signed-off-by: Minos Galanakis <[email protected]>
gilles-peskine-arm
added
needs-review
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
Signed-off-by: Minos Galanakis <[email protected]>
gilles-peskine-arm
approved these changes
Feb 28, 2025
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
gilles-peskine-arm
merged commit b55fd70
into
Mbed-TLS:features/tls-defragmentation/3.6
6 checks passed
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #9989
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.