Fix some all.sh components with sub-components #9293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
needs-review
gilles-peskine-arm
force-pushed
the
outcome-check-repeated-configurations-all.sh-preliminaries
branch
from
8bc7ce2 to
d8ae3d4
Compare
6 tasks
gilles-peskine-arm
force-pushed
the
outcome-check-repeated-configurations-all.sh-preliminaries
branch
from
6bc0245 to
3856d5c
Compare
gilles-peskine-arm
added
needs-ci
gilles-peskine-arm
added
needs-review
4 tasks
yanesca
added
needs-work
and removed
needs-review
yanesca
requested changes
Aug 5, 2024
Our makefiles don't use $(LD) so the typo was harmless. Signed-off-by: Gilles Peskine <[email protected]>
`grep mbedtls_des*` would pick up e.g. mbedtls_derive_xxx. Signed-off-by: Gilles Peskine <[email protected]>
The compilation is slower but we get more potential warnings and running the tests is faster. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Having assembly files called *.o was confusing. Signed-off-by: Gilles Peskine <[email protected]>
Reorganize the structure of the builds of aesce.c and sha256ce.c with various configurations of AES/SHA256 acceleration. Now everything in a given configuration is grouped together (building the object file, and checking the presence or absence of certain instructions in the assembly). Fix several instances of copypasta in -m options where we were sometimes not allowing the compiler to use optional instructions even though we use them in inline assembly, and sometimes allowing the compiler to use optional instructions even though we then checked their absence Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
outcome-check-repeated-configurations-all.sh-preliminaries
branch
from
3856d5c to
59aea4e
Compare
|
I rebased to resolve the conflicts, mostly in The following command shows that the new changeset differs from the old one only by file names and (in a few places) context, but the line changes are the same. |
yanesca
approved these changes
Aug 5, 2024
gilles-peskine-arm
added
needs-review
5 tasks
gilles-peskine-arm
added
the
needs-backports
5 tasks
waleed-elmelegy-arm
approved these changes
Sep 24, 2024
gilles-peskine-arm
added
approved
5 tasks
Merged
via the queue into
Mbed-TLS:development
with commit Oct 25, 2024
665df83
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of fixes to issues in
all.shthat I discovered while working on #9286. The biggest part is a reorganization ofcomponent_build_aes_armceandcomponent_build_sha_armceto make them split into clear distinct configurations.While the issues themselves are minor, this pull request is priority-high because it blocks priority-high work.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")