Backport 3.6: Fix some all.sh components with sub-components #9608
+74
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our makefiles don't use $(LD) so the typo was harmless. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-ci
This was referenced Sep 20, 2024
`grep mbedtls_des*` would pick up e.g. mbedtls_derive_xxx. Signed-off-by: Gilles Peskine <[email protected]>
The compilation is slower but we get more potential warnings and running the tests is faster. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Having assembly files called *.o was confusing. Signed-off-by: Gilles Peskine <[email protected]>
Reorganize the structure of the builds of aesce.c and sha256ce.c with various configurations of AES/SHA256 acceleration. Now everything in a given configuration is grouped together (building the object file, and checking the presence or absence of certain instructions in the assembly). Fix several instances of copypasta in -m options where we were sometimes not allowing the compiler to use optional instructions even though we use them in inline assembly, and sometimes allowing the compiler to use optional instructions even though we then checked their absence Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
outcome-check-repeated-configurations-all.sh-preliminaries-3.6
branch
from
f6d4e03 to
77e6ded
Compare
gilles-peskine-arm
added
needs-review
yanesca
approved these changes
Oct 10, 2024
waleed-elmelegy-arm
added
approved
Merged
via the queue into
Mbed-TLS:mbedtls-3.6
with commit Oct 25, 2024
91972cc
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some issues I discovered while working on #9286. Backport of #9293, conceptually identical, but with a lot of merge conflicts due to changes on the same line: we have lines that refer to
${BUILTIN_SRC_PATH}indevelopment, but that's justlibraryin 3.6.PR checklist