Skip to content

Backport 2.28: Fix some all.sh components with sub-components #9609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2024
Merged

Backport 2.28: Fix some all.sh components with sub-components #9609

merged 3 commits into from
Oct 25, 2024

Conversation

gilles-peskine-arm
Copy link
Contributor

Partial backport of #9608: some bug fixes in all.sh. I'm not backporting the changes to library/Makefile to support building assembly files because that was only needed for components added in 3.x.

PR checklist

@gilles-peskine-arm
Don't set LD to a path with a typo for mingw
c61187f 
Our makefiles don't use $(LD) so the typo was harmless.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm
Fix spurious * in regex
8214340 
`grep mbedtls_des*` would pick up e.g. mbedtls_derive_xxx.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm
Use -O2 for build+test with earliest compilers
bfe4fc6 
The compilation is slower but we get more potential warnings and running the
tests is faster.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests component-test Test framework and CI scripts priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Sep 20, 2024
This was referenced Sep 20, 2024
Merged
Merged
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Sep 24, 2024
yanesca
yanesca approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a faithful backport of the 3 relevant commits.

waleed-elmelegy-arm
waleed-elmelegy-arm approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@waleed-elmelegy-arm waleed-elmelegy-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waleed-elmelegy-arm waleed-elmelegy-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Oct 25, 2024
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Oct 25, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 9870921 Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanesca yanesca yanesca approved these changes

@waleed-elmelegy-arm waleed-elmelegy-arm waleed-elmelegy-arm approved these changes

Assignees

No one assigned

Labels

approved Design and code approved - may be waiting for CI or backports component-test Test framework and CI scripts priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Projects

Roadmap pull requests (new board)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gilles-peskine-arm @yanesca @waleed-elmelegy-arm