chore: rename source other to manual #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the SourceOther class and related references to SourceManual to improve clarity for users about manual scope configuration requirements.
- Renamed
SourceOtherclass toSourceManualwith corresponding field name change - Updated type annotations and error messages to use the new naming
- Simplified error message format for better readability
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for c0ce9ab. 🟢 All jobs passed!But CI Insights is watching 👀 |
jd
previously approved these changes
Oct 14, 2025
It makes more obvious that user has to do other stuffs manually. Change-Id: Ice3f956e29313e5f2f7552d2fb229bdfe7a9d5b3
sileht
force-pushed
the
devs/sileht/cli2-other/Ice3f956e29313e5f2f7552d2fb229bdfe7a9d5b3
branch
from
4433789 to
c0ce9ab
Compare
Greesb
approved these changes
Oct 14, 2025
Syffe
approved these changes
Oct 14, 2025
mergify
bot
deleted the
devs/sileht/cli2-other/Ice3f956e29313e5f2f7552d2fb229bdfe7a9d5b3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes more obvious that user has to do other stuffs manually.