Skip to content

chore: rename source other to manual #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Oct 14, 2025
Merged

chore: rename source other to manual #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions mergify_cli/ci/scopes/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ class SourceFiles(pydantic.BaseModel):
files: dict[ScopeName, FileFilters]


class SourceOther(pydantic.BaseModel):
other: None
class SourceManual(pydantic.BaseModel):
manual: None


class ScopesConfig(pydantic.BaseModel):
model_config = pydantic.ConfigDict(extra="forbid")

mode: typing.Literal["serial", "parallel"] = "serial"
source: SourceFiles | SourceOther | None = None
source: SourceFiles | SourceManual | None = None
merge_queue_scope: str | None = "merge-queue"


Expand Down Expand Up @@ -158,10 +158,8 @@ def detect(config_path: str) -> DetectedScope:
changed = changed_files.git_changed_files(base.ref)
all_scopes = set(source.files.keys())
scopes_hit, per_scope = match_scopes(changed, source.files)
elif isinstance(source, SourceOther):
msg = (
"source `other` has been set, scopes must be send with `scopes-send` or API"
)
elif isinstance(source, SourceManual):
msg = "source `manual` has been set, scopes must be send with `scopes-send` or API"
raise exceptions.ScopesError(msg)
else:
msg = "Unsupported source type" # type:ignore[unreachable]
Expand Down