Skip to content

fix: create-package script#5123

Merged
cryptodev-2s merged 2 commits intomainfrom
cryptodev2s/fix-yarn-create-package-script
Jan 10, 2025
Merged

fix: create-package script#5123
cryptodev-2s merged 2 commits intomainfrom
cryptodev2s/fix-yarn-create-package-script

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Jan 9, 2025

Explanation

This PR addresses a bug in the yarn create-package script introduced in this change, where fstatSync was replaced with await fs.stat(packagePath)).isDirectory().

The issue arises because fs.stat now throws an ENOENT error if the packagePath is empty. To resolve this, the script has been updated to handle empty paths gracefully, ensuring the process works as expected when creating new packages.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@cryptodev-2s cryptodev-2s added the team-wallet-framework Deprecated: Please use `team-core-platform` instead. label Jan 9, 2025
@cryptodev-2s cryptodev-2s requested a review from mcmire January 9, 2025 23:34
@cryptodev-2s cryptodev-2s self-assigned this Jan 9, 2025
@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/fix-yarn-create-package-script branch from 7cba979 to dcd4406 Compare January 9, 2025 23:39
@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/fix-yarn-create-package-script branch from ccd34be to 4eff1cb Compare January 10, 2025 00:34
@cryptodev-2s cryptodev-2s enabled auto-merge (squash) January 10, 2025 00:38
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cryptodev-2s cryptodev-2s merged commit 3a7e6cb into main Jan 10, 2025
120 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/fix-yarn-create-package-script branch January 10, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-wallet-framework Deprecated: Please use `team-core-platform` instead.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants