Skip to content

Comments

feat: STAKE-942: add pooled staking vault daily apys and vault apy averages to earn controller#5368

Merged
Matt561 merged 5 commits intomainfrom
feat/stake-942-add-pooled-staking-vault-daily-apys-and-vault-apy-averages-to-earn-controller
Feb 21, 2025
Merged

feat: STAKE-942: add pooled staking vault daily apys and vault apy averages to earn controller#5368
Matt561 merged 5 commits intomainfrom
feat/stake-942-add-pooled-staking-vault-daily-apys-and-vault-apy-averages-to-earn-controller

Conversation

@Matt561
Copy link
Contributor

@Matt561 Matt561 commented Feb 20, 2025

Explanation

This PR adds the pooled staking VaultDailyApys and VaultApyAverages state and related refresh methods to the EarnController.

Also,vaultData state has been renamed to vaultMetadata to differentiate it from other vault-related state.

References

Changelog

@metamask/earn-controller

  • ADDED: Pooled staking VaultDailyApys[] state and refresh method.
  • ADDED: Pooled staking VaultApyAverages state and refresh method.
  • CHANGED: Renamed vaultData to vaultMetadata for related state and refresh method.
  • CHANGED: Updated existing tests to support new and renamed state

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Matt561 Matt561 force-pushed the feat/stake-942-add-pooled-staking-vault-daily-apys-and-vault-apy-averages-to-earn-controller branch 2 times, most recently from b9f9778 to 0f036e8 Compare February 20, 2025 21:54
@Matt561 Matt561 force-pushed the feat/stake-942-add-pooled-staking-vault-daily-apys-and-vault-apy-averages-to-earn-controller branch from 0f036e8 to 4ecb90a Compare February 20, 2025 21:55
@Matt561 Matt561 marked this pull request as ready for review February 20, 2025 21:57
@Matt561 Matt561 requested a review from a team as a code owner February 20, 2025 21:57
@Matt561 Matt561 requested a review from amitabh94 February 20, 2025 22:27
@Matt561 Matt561 force-pushed the feat/stake-942-add-pooled-staking-vault-daily-apys-and-vault-apy-averages-to-earn-controller branch from fc1090e to 93b273c Compare February 21, 2025 15:41
@Matt561 Matt561 requested a review from amitabh94 February 21, 2025 15:42
…y-apys-and-vault-apy-averages-to-earn-controller
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matt561 Matt561 enabled auto-merge (squash) February 21, 2025 15:47
@Matt561 Matt561 merged commit e20cee3 into main Feb 21, 2025
136 checks passed
@Matt561 Matt561 deleted the feat/stake-942-add-pooled-staking-vault-daily-apys-and-vault-apy-averages-to-earn-controller branch February 21, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants