Ensure descriptions appear correctly.#2096
Merged
bgravenorst merged 2 commits intomainfrom Jun 18, 2025
Merged
Conversation
Signed-off-by: bgravenorst <byron.gravenorst@consensys.net>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where parameter descriptions were lost when schema references were resolved in the API documentation renderer.
- Updated the resolveRef function in RenderParams.tsx to preserve the original parameter’s description.
- Ensured that the fallback mechanism considers the original description before defaulting to the schema's title.
Comments suppressed due to low confidence (1)
src/components/ParserOpenRPC/DetailsBox/RenderParams.tsx:15
- Consider adding unit tests to verify that the original parameter description is preserved when resolving schema references.
const resolveRef = (ref, originalItem) => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve parameter descriptions when resolving schema references
Problem
Parameter descriptions were not displaying correctly when parameters used schema references (
$ref). Instead of showing the parameter-specific descriptions, the parser was displaying the generic schema titles from the referenced components.Root Cause
The
resolveReffunction inRenderParams.tsxwas losing the original parameter's description when resolving schema references. When a parameter had a$refschema, the function would:renderSchemawith only the resolved schemaSolution
Modified the
resolveReffunction to preserve the original parameter's description when resolving references:Testing
Ensure descriptions are now displaying for methods like
eth_decrypt,eth_feeHistoryeth_getEncryptionPublicKey.Ensure we still fallback to the types
titlewhen descriptions are absent.Fixes
Fixes #2089
Checklist
Complete this checklist before merging your PR: